Page MenuHomePhabricator

"Expand 10 before" and "Expand 10 after" broken on some pages
Closed, ResolvedPublic

Description

Clicking "Expand 10 after" on https://gerrit.wikimedia.org/r/#/c/14040/1/wmf-config/InitialiseSettings.php doesn't work.

Firebug:

uncaught exception: Class$LXb: One or more exceptions caught, see full set in UmbrellaException#getCauses
https://gerrit.wikimedia.org/r/gerrit/F603A082B141A26D031D8A8E3846A902.cache.html
Line 1767


Version: unspecified
Severity: normal
URL: http://code.google.com/p/gerrit/issues/detail?id=1233
See Also:
http://code.google.com/p/gerrit/issues/detail?id=1233
https://bugzilla.wikimedia.org/show_bug.cgi?id=45309

Details

Reference
bz38144

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:54 AM
bzimport added projects: Gerrit, Upstream.
bzimport set Reference to bz38144.
bzimport added a subscriber: Unknown Object (MLST).

This is an upstream bug, already filed.

Verified on Firefox and Chromium.

Nemo_bis: Verified as in "Verified fixed", or verified as in "issue exists"? :)

(In reply to comment #3)

Nemo_bis: Verified as in "Verified fixed", or verified as in "issue exists"? :)

The latter. As the upstream bug says, it's definitely gerrit's fault because big files are not loaded at all, so except the diff nothing else can be shown.

sumanah wrote:

Chad, I see that the patch upstream is running into review questions/critique; can you check on that at all and tell us how likely it is to be fixed by Gerrit 2.6?

This is broken for me on all diffs now, grrr :\

(In reply to comment #8)

This is broken for me on all diffs now, grrr :\

Split to bug 45309 (I think).

This is the same bug, don't see the point in splitting.

  • Bug 45309 has been marked as a duplicate of this bug. ***

(In reply to comment #10)

This is the same bug, don't see the point in splitting.

Ok:

(In reply to comment #11)

  • Bug 45309 has been marked as a duplicate of this bug. ***

Is this broken for anyone but me anymore?

Fwiw, this has remained broken for me in Chrome on OSX (for the past couple of versions, at least). I've been unable to replicate using any other browser on OSX, or when using Chrom(e|ium) on other platforms.

(In reply to comment #13)

Is this broken for anyone but me anymore?

Yes.

Broken for me with Chrome on Linux for since the last(?) Gerrit upgrade. Somewhat annoying.

  • Bug 48648 has been marked as a duplicate of this bug. ***

Finally fixed with 2.7-rc2-505-g7502a46.