| Dereckson | |
| Jun 6 2012, 9:34 PM |
| F9537: Gerrit-UI-ImagesDiff.png | |
| Nov 22 2014, 12:29 AM |
+++ This bug was initially created as a clone of Bug #36852 +++
When a git commit contains changes to a picture file, the Gerrit UI interface prints:
This isn't intuitive nor ergonomic and could mislead a reviewer.
Version: unspecified
Severity: minor
URL: https://gerrit.wikimedia.org/r/#/c/9591
See Also:
http://code.google.com/p/gerrit/issues/detail?id=1426
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • demon | T39382 Gerrit doesn't show links to diff pictures a consistent way | |||
| Resolved | • demon | T38852 Gerrit doesn't show image updates side by side |
Created attachment 10697
Gerrit change 9591 - an image diff
Image diff links
Attached:
Adding upstream keyword.
Upstream bug: http://code.google.com/p/gerrit/issues/detail?id=1426
(In reply to comment #0)
When a git commit contains changes to a picture file, the Gerrit UI interface
prints:
- two links to see the old and the now pictures in the Side-by-side column
- a link to see both logos side by side in the unified column
This isn't intuitive nor ergonomic and could mislead a reviewer.
This has changed in the meantime.
On https://gerrit.wikimedia.org/r/#/c/9591 I only get "Binary files differ" now when trying to view the diff.
Wondering which behavior is requested in this bug report.
Dereckson, could you clarify?
Wondering which behavior is requested in this bug report.
Dereckson, could you clarify?
This is for cleaning up the links to diffs. Which seems to be fixed (although the bug was never closed upstream).
The other bug (about image diffs not showing) is bug 47519 (which is now fixed too).