Page MenuHomePhabricator

Unable to open diff in Gerrit
Closed, ResolvedPublic

Description

See the i18n file in the url mentioned.

RangeError
arguments: Array[0]
get message: function getter() { [native code] }
get stack: function getter() { [native code] }
set message: function setter() { [native code] }
set stack: function setter() { [native code] }
type: "stack_overflow"
proto: Error
console.trace()
X
Y
_1b48516D3A05069B02085F4C99B3ECCB44.cache.html:206
Y1b48516D3A05069B02085F4C99B3ECCB44.cache.html:186
L1b48516D3A05069B02085F4C99B3ECCB44.cache.html:350
AWb48516D3A05069B02085F4C99B3ECCB44.cache.html:301
Mxb48516D3A05069B02085F4C99B3ECCB44.cache.html:357
opb48516D3A05069B02085F4C99B3ECCB44.cache.html:165
Jub48516D3A05069B02085F4C99B3ECCB44.cache.html:353
Pvb48516D3A05069B02085F4C99B3ECCB44.cache.html:357
UI48516D3A05069B02085F4C99B3ECCB44.cache.html:2949
wHd48516D3A05069B02085F4C99B3ECCB44.cache.html:2520
pKd48516D3A05069B02085F4C99B3ECCB44.cache.html:2961
eLc48516D3A05069B02085F4C99B3ECCB44.cache.html:2596
MLc48516D3A05069B02085F4C99B3ECCB44.cache.html:2958
(anonymous function)48516D3A05069B02085F4C99B3ECCB44.cache.html:2093
Avc48516D3A05069B02085F4C99B3ECCB44.cache.html:2229
(anonymous function)48516D3A05069B02085F4C99B3ECCB44.cache.html:2179
48516D3A05069B02085F4C99B3ECCB44.cache.html:2179Uncaught Class$QKd: Array index 277 out of range


Version: unspecified
Severity: major
URL: https://gerrit.wikimedia.org/r/#change,5220,patchset=1
See Also:
http://code.google.com/p/gerrit/issues/detail?id=1492

Details

Reference
bz36172

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:19 AM
bzimport set Reference to bz36172.
bzimport added a subscriber: Unknown Object (MLST).

It's not a big diff by any means.

Ryan Lane has posted comments on this change.
I can in firefox, I can't in chrome.

Could someone file this one upstream? Looks like we're talking about a single strange diff here, so bumping down priority

Please report this information upstream. There's nothing I can do with more links just being added.

I have not communicated with Gerrit upstream and don't want to start now.

Only today this has bothered me about five times.

(In reply to comment #11)

Only today this has bothered me about five times.

Ok. I get the point. Continuing to +1 and "omg this one too" and "PLZ HELP" do not help me solve this /at all/.

In case you're interested, I have been talking to upstream about how to fix this, and I'm also attempting to replicate on my local installation. Just because I haven't given daily status updates doesn't mean nothing is happening.

Managed to replicate this locally and get a slightly more useful stacktrace.

http://p.defau.lt/?tPAD0WdwDCMLmibBxtXZ9Q

Unfortunately, I think it might be an issue with GWT upstream from Gerrit, but I'll continue to pester and find out.

I'm pretty sure this isn't a duplicate of anything else upstream, so I filed a new issue to track it: http://code.google.com/p/gerrit/issues/detail?id=1492

Thanks Chad. I will follow the developments quietly. +1 ;)

At the moment all of the files mentioned to not display a diff in this issue report are "Works for me". I'm using Firefox 16.0.1 on OSX 10.8.2.

https://gerrit.wikimedia.org/r/#/c/29925/2/MoodBar.i18n.php was reported to not display a diff in gerrit 29925, but that's works for me, too.

(In reply to comment #17)
It's chrome specific, as mentioned in #c4. Updated Web Browser field.

I believe this was fixed, I can't seem to replicate in Chrome for any of the above mentioned diffs.

Cannot reproduce either in Chrome 24.0.1312.69 with the given URLs (being not logged in to Gerrit).

<^demon> It was probably https://code.google.com/p/gerrit/issues/detail?id=1759.
<^demon> Or https://code.google.com/p/gerrit/issues/detail?id=735
<^demon> But one of those two definitely fixed 1492

Closing as FIXED.