Page MenuHomePhabricator
Create Task
Maniphest T37860

Gerrit is a browser memory hog
Closed, DeclinedPublic
Actions

Description

Gerrit is a browser memory hog and/or makes my browser hang when "Diff all side-by-side" of https://gerrit.wikimedia.org/r/#change,4631. Seems to be caused by tests/messageindexdata.ser. I think Gerrit probably shouldn't just open these kind of files.

FF11 used 1.2GB when done after a few minutes.

Steps to reproduce:

  1. Open https://gerrit.wikimedia.org/r/#/c/4631/1/tests/messageindexdata.ser

I. Observed, Chromium 44.0.2403.157: CPU usage 100 % and RAM usage increases indefinitely; the "unresponding window" turns up and by terminating it the second time RAM usage is limited to 600 MB.
II. Observed, Firefox 39.0: CPU usage is 100 % indefinitely, browser freezes entirely; RAM usage increases for a bit (200 MB?) and then goes down. The browser has to be terminated by the OS.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.mozilla.org/show_bug.cgi?id=842623

Details

Reference
bz35860

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:11 AM
• bzimport added projects: Browser-Support-Firefox, Gerrit, Upstream.
• bzimport set Reference to bz35860.
• bzimport added a subscriber: Unknown Object (MLST).
siebrand created this task.Apr 10 2012, 4:45 PM
Aklapper added a comment.Feb 19 2013, 5:19 PM

A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete.
<andre__> Script: https://gerrit.wikimedia.org/r/gerrit_ui/CF42DB02C9A85777BE331C90AA0419DE.cache.html:4386

I've forwarded this to https://bugzilla.mozilla.org/show_bug.cgi?id=842623 .

Nemo_bis added a comment.Feb 6 2014, 8:52 AM

(In reply to comment #1)

I've forwarded this to https://bugzilla.mozilla.org/show_bug.cgi?id=842623 .

Marked needinfo since 2013-08-26, maybe someone other than Andre can add more information there.

• demon unsubscribed.Dec 8 2014, 6:33 PM
TheDJ moved this task from Backlog to Reported Upstream on the Upstream board.Mar 29 2015, 10:37 PM
hashar closed this task as Declined.Jul 6 2015, 12:11 PM
hashar claimed this task.
hashar subscribed.

I don't think this is much of an issue nowadays. I haven't heard about such complaint recently and since the bug has been opened: we upgraded Gerrit, new browsers versions have been released. IIRC one of the issue we had was looking at diff views with syntax highlighting. In my experience that is no more causing any issue.

Thus abandoning this bug. No point in keeping it idle here.

Nemo_bis added a comment.Jul 6 2015, 3:08 PM

I doubt this issue has ever solved. Personally, I just stopped clicking the things which I know will crash my browser, and I switched to the new change screen which has less issue (though due to T65847 we're stuck to an ancient version, the worst available in the whole history of gerrit releases probably).

Nemo_bis updated the task description. (Show Details)Sep 4 2015, 7:36 AM
Nemo_bis added a project: Browser-Support-Google-Chrome.
Nemo_bis set Security to None.
Dalba awarded a token.Jan 3 2016, 12:04 PM
• demon mentioned this in T53164: Specific diff fails to load.Jul 25 2016, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL